I think this is good advise! Just like checking your "UN-LOADED" GUN. We become complacent about our equipment and in doing so our safety. I always check my tank valve, take at least a puff off my regulator and ocoto, inflate my BC, and make sure the family jewels are comfortable before every dive (one can never be too care about that). A quick check may not protect against an unforeseen failure but it beats splashing just to bob up out of breath from the valve you were sure you opened.
To the weight check, with my weight integrated B.C. I’m usually checking that they wont fall out so the release gets checked when I load them.